Skip to content

chore: add .claude/tsc-cache to .gitignore#115

Open
ian-flores wants to merge 1 commit intomainfrom
add-tsc-cache-gitignore
Open

chore: add .claude/tsc-cache to .gitignore#115
ian-flores wants to merge 1 commit intomainfrom
add-tsc-cache-gitignore

Conversation

@ian-flores
Copy link
Collaborator

Summary

  • Add .claude/tsc-cache/ to .gitignore to prevent accidentally committing Claude Code TypeScript cache files

Test plan

  • Verify .gitignore syntax is correct
  • Confirm the pattern matches .claude/tsc-cache/ directory

This prepares main branch to properly ignore tsc-cache files before cleaning them from PR #94.

@claude
Copy link

claude bot commented Mar 5, 2026

Claude finished @ian-flores's task —— View job


PR Review: Add .claude/tsc-cache to .gitignore

  • Read review guidelines
  • Get PR diff and review changed files
  • Submit review

Reviewed this PR. The change is clean and correct — scoping the ignore to .claude/tsc-cache/ (rather than all of .claude/) is appropriate since .claude/ contains tracked config files. Left a review comment with that observation and a self-review norm reminder.

Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, minimal change. The .gitignore entry correctly targets .claude/tsc-cache/ and follows the existing file conventions (grouped section with a comment header).

Observations:

  • Scoping is correct: Since .claude/ contains tracked files (e.g., review-guidelines.md), ignoring only the tsc-cache/ subdirectory rather than the entire .claude/ directory is the right call.
  • Pattern syntax: .claude/tsc-cache/ with the trailing slash correctly matches only the directory, which is appropriate here.
  • PR description note: The description mentions this prepares main for cleaning tsc-cache from PR #94 — that sequencing makes sense.

Self-review norm reminder: Per the repo's review guidelines, consider adding inline comments on your own diffs to highlight key decisions for reviewers (e.g., why tsc-cache specifically rather than the whole .claude/ directory).

@ian-flores ian-flores enabled auto-merge March 6, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant