fix(ci): push to GHCR on main branch before Docker Hub#33
Merged
ian-flores merged 1 commit intomainfrom Jan 13, 2026
Merged
Conversation
The push-dockerhub job pulls from GHCR, but the image was only pushed to GHCR for PR builds. Added a step to push to GHCR on main branch so push-dockerhub can pull and re-tag for Docker Hub.
|
Claude finished @ian-flores's task —— View job Review Complete
The fix correctly addresses the root cause where |
There was a problem hiding this comment.
The fix correctly addresses the root cause: push-dockerhub job (line 200) pulls from GHCR (line 214), but the image was never pushed there on main branch.
The change is minimal and well-placed - it reuses the existing full-image output and runs right after GHCR login.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The push-dockerhub job pulls from GHCR, but the image was only pushed to GHCR for PR builds. This adds a step to push to GHCR on main branch so push-dockerhub can pull and re-tag for Docker Hub.
Problem
On main branch:
docker pullfrom GHCRFix
Added "Push to GHCR (main branch)" step that runs before push-dockerhub job.
Test plan