fix(connect): declare rmarkdown closure and raise deploy timeout#218
fix(connect): declare rmarkdown closure and raise deploy timeout#218ian-flores merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Connect deployment test fixtures and configuration defaults to make R Markdown deploys more reliable on Connect instances where Posit Package Manager does not allow anonymous access to transitive CRAN dependencies, and to accommodate longer restore/build times.
Changes:
- Replace the
vip-rmarkdown-testmanifest stub with a checked-in full transitive R package closure loaded fromrmarkdown_manifest.json. - Increase the default
connect.deploy_timeoutfrom 600s to 1200s in config parsing, example config, and selftests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
vip.toml.example |
Updates documented default and example deploy_timeout value to 1200s. |
src/vip_tests/connect/test_content_deploy.py |
Loads a pre-built R Markdown manifest JSON and injects the server’s R platform version at runtime. |
src/vip_tests/connect/rmarkdown_manifest.json |
Adds a full 31-package R dependency closure for the R Markdown deployment test manifest. |
src/vip/config.py |
Raises the default Connect deploy_timeout and the fallback used when config omits it. |
selftests/test_config.py |
Updates assertions to match the new 1200s default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📸 Preview Screenshot SummaryTriggered by: Website Preview workflow run #409 (
|
| Preview | URL | Status |
|---|---|---|
| 🌐 Website | https://posit-dev.github.io/vip/pr-preview-site/pr-218/ |
❌ 404 |
| 📊 Report | https://posit-dev.github.io/vip/pr-preview/pr-218/ |
❌ 404 |
Screenshots Captured: 2
Both screenshots show the GitHub Pages 404 page (previews were removed before capture).
Website preview (https://posit-dev.github.io/vip/pr-preview-site/pr-218/)
Report preview (https://posit-dev.github.io/vip/pr-preview/pr-218/)
Note: The Website Preview deployed successfully, but the PR was closed shortly after, triggering cleanup of both preview deployments before screenshots could be captured. For future runs, consider merging/closing PRs only after reviewing the previews.
Generated by Capture preview screenshots for PRs · ● 5.3M · ◷
Summary
_get_bundleforvip-rmarkdown-testwith a full 31-package transitive closure loaded from a newsrc/vip_tests/connect/rmarkdown_manifest.json(mirrors thevip-shiny-testpattern). Emptypackagescausedr-cannot-access-repoon deployments where PPM doesn't serve transitive deps anonymously.connect.deploy_timeoutfrom 600s to 1200s. R-heavy content with many source-built packages (rmarkdown, shiny) legitimately needs >10 min on deployments where PPM falls back to CRAN source builds.vip.toml.examplecomment, config default, and two selftest assertions to reflect the new default.Test plan
uv run ruff check src/ selftests/— cleanuv run ruff format --check src/ selftests/— 102 files already formatteduv run pytest selftests/ -q— 318 passedvip verify --connect-url https://pub.ganso.lab.staging.posit.team --filter deploy_rmarkdown -- -n 0against ganso01-staging —test_deploy_rmarkdown PASSEDin 603s. Packrat restores all 31 packages (PPM 401 → CRAN 200 fallback), rmd-static renders, HTML contains "VIP RMarkdown Test" marker.Fixes #214