Skip to content

chore(deps): bump mako and mistune to fix CVEs#249

Merged
ian-flores merged 1 commit intomainfrom
bump-mako-mistune-cve-fixes
May 8, 2026
Merged

chore(deps): bump mako and mistune to fix CVEs#249
ian-flores merged 1 commit intomainfrom
bump-mako-mistune-cve-fixes

Conversation

@ian-flores
Copy link
Copy Markdown
Collaborator

Summary

pip-audit flagged two transitive CVEs on every recent CI run, including main:

  • mako 1.3.10CVE-2026-44307 (fix in 1.3.12). Transitive via pytest-bdd.
  • mistune 3.2.0CVE-2026-33079 (fix in 3.2.1). Transitive via nbconvert.

Pinning the safe versions inline in pyproject.toml follows the existing pattern (requests, pygments, python-multipart, pip, nbconvert, tornado, pyjwt, cryptography).

Test plan

  • uvx pip-audit --skip-editable: no known vulnerabilities
  • uv run pytest selftests/: 446 passed
  • uv run ruff check src/ src/vip_tests/ selftests/ examples/
  • uv run ruff format --check src/ src/vip_tests/ selftests/ examples/

Both surfaced via pip-audit in CI on main:
- mako 1.3.10 → 1.3.12 fixes CVE-2026-44307. Transitive via pytest-bdd.
- mistune 3.2.0 → 3.2.1 fixes CVE-2026-33079. Transitive via nbconvert.

Pinning each in pyproject.toml follows the existing pattern for transitive
CVE fixes (see requests, pygments, python-multipart, pip, nbconvert,
tornado, pyjwt, cryptography).
Copilot AI review requested due to automatic review settings May 8, 2026 18:55
@ian-flores ian-flores marked this pull request as ready for review May 8, 2026 18:56
@ian-flores ian-flores requested review from bdeitte and statik as code owners May 8, 2026 18:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses pip-audit findings by explicitly pinning minimum safe versions for two transitive dependencies (mako and mistune) in pyproject.toml, following the project’s existing “pin to safe lower bound with CVE comment” pattern.

Changes:

  • Add mako>=1.3.12 to core dependencies to remediate CVE-2026-44307 (via pytest-bdd).
  • Add mistune>=3.2.1 to the report optional extra to remediate CVE-2026-33079 (via nbconvert).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ian-flores ian-flores merged commit 7d47e6d into main May 8, 2026
27 checks passed
@ian-flores ian-flores deleted the bump-mako-mistune-cve-fixes branch May 8, 2026 19:02
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-05-08 19:02 UTC

@github-actions github-actions Bot mentioned this pull request May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants