Skip to content

Fix nested json parsing errors #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ai merged 1 commit into from
Oct 4, 2024
Merged

Fix nested json parsing errors #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/safe-parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class SafeParser extends Parser {
for (nextStart = colon - 1; nextStart >= 0; nextStart--) {
if (tokens[nextStart][0] === 'word') break
}
if (nextStart === 0) return
if (nextStart === 0 || nextStart < 0) return

for (prevEnd = nextStart - 1; prevEnd >= 0; prevEnd--) {
if (tokens[prevEnd][0] !== 'space') {
Expand Down
33 changes: 33 additions & 0 deletions test/parse.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,38 @@ test('fixes colon instead of semicolon', () => {
equal(root.toString(), 'a { one: 1: } b { one: 1 : }')
})

test('fixes {} error', () => {
let root = parse(`:root { --example-var: { "Version": { "Build": "10.30.7.350828.20230224122352", "Source": "10.30.7.350828.1", "Required": "10.30.7.307232"; }}}; @font-face { font-family: 'Calibri'; }`)
equal(root.toString(), `:root { --example-var: { "Version": { "Build": "10.30.7.350828.20230224122352", "Source": "10.30.7.350828.1", "Required": "10.30.7.307232"; }}}; @font-face { font-family: 'Calibri'; }`)
})

test('Rule at the start of tokens', () => {
let root = parse(`.start { font-size: 16px; }`);
equal(root.toString(), `.start { font-size: 16px; }`);
});

test('Complex nested structures with JSON-like properties', () => {
let root = parse(`:root { --complex: {"nested": {"key": "value"}, "array": [1, {"sub": "value"}]}; } @font-face { font-family: 'Calibri'; }`);
equal(root.toString(), `:root { --complex: {"nested": {"key": "value"}, "array": [1, {"sub": "value"}]}; } @font-face { font-family: 'Calibri'; }`);
});

test('Multiple rules with one JSON-like custom property', () => {
let root = parse(`
.class1 { margin: 10px; }
:root { --jsonProp: {"a": 1, "b": {"c": 3}}; }
.class2 { padding: 20px; }
`);
equal(root.toString(), `
.class1 { margin: 10px; }
:root { --jsonProp: {"a": 1, "b": {"c": 3}}; }
.class2 { padding: 20px; }
`);
});

test('Custom property at start without modifications', () => {
let root = parse(`--example: {"key": "value"}; .class { color: black; }`);
equal(root.toString(), `--example: {"key": "value"}; .class { color: black; }`);
});

test.run()