Fix worker segfault on shutdown from leaked log-reader thread - #422
Merged
Conversation
logger.py: start TestgresLogger with deamon=true node.py: run pg_ctl stop in try/finally
demonolock
force-pushed
the
fix-core-dump
branch
from
July 30, 2026 13:19
8dd79c6 to
919e132
Compare
Ogurezzz
approved these changes
Jul 31, 2026
demonolock
force-pushed
the
fix-core-dump
branch
3 times, most recently
from
August 2, 2026 14:28
6380df9 to
d1f819e
Compare
dmitry-lipetsk
self-requested a review
August 3, 2026 06:11
dmitry-lipetsk
requested changes
Aug 3, 2026
Collaborator
There was a problem hiding this comment.
Виктория, привет.
Я не согласен с таким огромным количеством изменений, которые не имеют отношения к проблеме.
В проекте специально использовались:
- старые аннотации типов typing.XXX
- format вместо f-строк
Некоторые другие изменения полезные, но не надо это все пытаться затащить через этот патч.
Contributor
Author
|
@dmitry-lipetsk у мнея линтер падал без них |
demonolock
force-pushed
the
fix-core-dump
branch
from
August 3, 2026 08:49
d1f819e to
92415d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logger.py: start TestgresLogger with deamon=true
node.py: run pg_ctl stop in try/finally