Emit file option - #10
Merged
Scrum merged 2 commits intoApr 22, 2021
Merged
Conversation
Scrum
reviewed
Apr 20, 2021
|
|
||
| module.exports = function rollupPluginPosthtml (options) { | ||
| options = Object.assign({ | ||
| emitFile: true, |
Member
There was a problem hiding this comment.
It will be very good if you add a description of this option in the readmi
Collaborator
There was a problem hiding this comment.
I think it should default to false and save the current behavior, thus no breaking change bump.
Scrum
approved these changes
Apr 22, 2021
Member
|
@tunnckoCore Hi, could you please grant me the rights to npc for timely publication of new features? |
Collaborator
|
Heya, just was thinking does anyone else have npm rights to this. I can't now. I'm coming back to OSS in coming 2 weeks. It's easy task, but I don't have npm and the time to setup. |
Member
|
@tunnckoCore hello, is there an opportunity? |
Member
|
@tunnckoCore ping |
Member
|
@tunnckoCore ping ) |
Member
|
@tunnckoCore again ping |
Collaborator
|
@Scrum heya, i'll add you now. |
Collaborator
|
You are ready. Sorry. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no way to chain result of PostHTML generation to other Rollup modules as a raw string. The only possible format is a wrapped anonymous module. Such way of resource emitting can't satisfy template precompiling plugins (like https://github.com/nilennoct/rollup-plugin-dot). I propose to introduce an optional unwrapped export