Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions fixtures/www.ndtv.com/1587821636077.html

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/extractors/custom/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,3 +140,4 @@ export * from './www.abendblatt.de';
export * from './www.gruene.de';
export * from './www.engadget.com';
export * from './arstechnica.com';
export * from './www.ndtv.com';
54 changes: 54 additions & 0 deletions src/extractors/custom/www.ndtv.com/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
export const WwwNdtvComExtractor = {
domain: 'www.ndtv.com',

title: {
selectors: [['meta[name="og:title"]', 'value'], 'h1.entry-title'],
},

author: {
selectors: ['span[itemprop="author"] span[itemprop="name"]'],
},

date_published: {
selectors: [['span[itemprop="dateModified"]', 'content']],
},

dek: {
selectors: ['h2'],
},

lead_image_url: {
selectors: [['meta[name="og:image"]', 'value']],
},

content: {
selectors: ['div[itemprop="articleBody"]'],

// Is there anything in the content you selected that needs transformed
// before it's consumable content? E.g., unusual lazy loaded images
transforms: {
// This site puts a dateline in a 'b' above the first paragraph, and then somehow
// blends it into the first paragraph with CSS. This transform moves the dateline
// to the first paragraph.
'.place_cont': $node => {
if (!$node.parents('p').length) {
const nextSibling = $node.next('p');
if (nextSibling) {
$node.remove();
nextSibling.prepend($node);
}
}
},
},

// Is there anything that is in the result that shouldn't be?
// The clean selectors will remove anything that matches from
// the result
clean: [
'.highlghts_Wdgt',
'.ins_instory_dv_caption',
'input',
'._world-wrapper .mt20',
],
},
};
120 changes: 120 additions & 0 deletions src/extractors/custom/www.ndtv.com/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
import assert from 'assert';
import URL from 'url';
import cheerio from 'cheerio';

import Mercury from 'mercury';
import getExtractor from 'extractors/get-extractor';
import { excerptContent } from 'utils/text';

const fs = require('fs');

describe('WwwNdtvComExtractor', () => {
describe('initial test case', () => {
let result;
let url;
beforeAll(() => {
url =
'https://www.ndtv.com/india-news/coronavirus-us-president-donald-trump-says-there-may-be-retaliation-if-india-doesnt-clear-export-of-2207327';
const html = fs.readFileSync(
'./fixtures/www.ndtv.com/1587821636077.html'
);
result = Mercury.parse(url, { html, fallback: false });
});

it('is selected properly', () => {
// This test should be passing by default.
// It sanity checks that the correct parser
// is being selected for URLs from this domain
const extractor = getExtractor(url);
assert.equal(extractor.domain, URL.parse(url).hostname);
});

it('returns the title', async () => {
// To pass this test, fill out the title selector
// in ./src/extractors/custom/www.ndtv.com/index.js.
const { title } = await result;

// Update these values with the expected values from
// the article.
assert.equal(
title,
`COVID-19: Trump Talks "Retaliation" If India Rejects Export Of Key Drug`
);
});

it('returns the author', async () => {
// To pass this test, fill out the author selector
// in ./src/extractors/custom/www.ndtv.com/index.js.
const { author } = await result;

// Update these values with the expected values from
// the article.
assert.equal(author, 'Swati Bhasin');
});

it('returns the date_published', async () => {
// To pass this test, fill out the date_published selector
// in ./src/extractors/custom/www.ndtv.com/index.js.
const { date_published } = await result;

// Update these values with the expected values from
// the article.
assert.equal(date_published, '2020-04-07T10:19:34.000Z');
});

it('returns the dek', async () => {
// To pass this test, fill out the dek selector
// in ./src/extractors/custom/www.ndtv.com/index.js.
const { dek } = await result;

// Update these values with the expected values from
// the article.
assert.equal(
dek,
'Amid rising pressure, the government is likely to take a decision on the matter today and clear the move after calculating sufficient stocks for the country, sources have told NDTV.'
);
});

it('returns the lead_image_url', async () => {
// To pass this test, fill out the lead_image_url selector
// in ./src/extractors/custom/www.ndtv.com/index.js.
const { lead_image_url } = await result;

// Update these values with the expected values from
// the article.
assert.equal(
lead_image_url,
`https://c.ndtvimg.com/2020-04/u9vkhue_donald-trump-white-house-afp_625x300_04_April_20.jpg`
);
});

it('returns the content', async () => {
// To pass this test, fill out the content selector
// in ./src/extractors/custom/www.ndtv.com/index.js.
// You may also want to make use of the clean and transform
// options.
const { content } = await result;

const $ = cheerio.load(content || '');

const first13 = excerptContent(
$('*')
.first()
.text(),
13
);

// Update these values with the expected values from
// the article.
assert.equal(
first13,
'Washington/ New Delhi: US President Donald Trump has said "there may be retaliation"'
);

// Confirm that the dateline is moved.
const dateline = $('.place_cont');
assert.equal(dateline.length, 1);
assert.equal(dateline.get(0).parent.tagName, 'p');
});
});
});