feat: Add a custom extractor for www.ndtv.com. #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing content for cron.weekly issues, such as the one at https://ma.ttias.be/cronweekly/issue-130/, Mercury Parser would remove headings and ordered lists that were part of the content. This resolves that as follows: * Remove "id" attributes from "h1" and "h2" elements. Those attributes would result in the elements having a low weight. * Since Mercury Parser demotes "h1" elements to "h2", demote "h2" elements to "h3". * Add class="entry-content-asset" to "ul" elements to avoid them being removed.
…e would send contentOnly: true on subsequent pages (page 2). removed failover: true from preview.
Feature arstechnica extractor
jbrayton
added a commit
to jbrayton/mercury-parser
that referenced
this pull request
Apr 27, 2020
nitinthewiz
reviewed
Jul 26, 2021
src/extractors/collect-all-pages.js
Outdated
| html, | ||
| $, | ||
| metaCache, | ||
| contentOnly: true, |
Contributor
There was a problem hiding this comment.
What is the logic behind removing this value?
Contributor
Author
There was a problem hiding this comment.
Sorry, I do not recall at this point. Obviously if I thought removing that value a good change I should have included comments around it. But I did not, and I did this over a year ago now.
Contributor
There was a problem hiding this comment.
FYI, it looks like there's some context for this change in #553
johnholdun
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.