Disables tests in the PM due to layout problems#9
Merged
lilyball merged 1 commit intopostmates:masterfrom Jan 17, 2017
hpux735:swiftpm
Merged
Disables tests in the PM due to layout problems#9lilyball merged 1 commit intopostmates:masterfrom hpux735:swiftpm
lilyball merged 1 commit intopostmates:masterfrom
hpux735:swiftpm
Conversation
Collaborator
|
Hmm, looks like it's not actually possible to make it compliant, because the tests rely on fixture files and SwiftPM doesn't seem to have a way to support those. |
Contributor
Author
|
Yah, it kinda sucks. That's why this PR just excludes that directory from SwiftPM. |
Collaborator
|
Thanks for the PR! |
Contributor
Author
|
Sure, thanks for PMJSON! 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I love using PMJSON, but I had to fork it to use it with the Swift package manager. The problem is that the structure of the Tests directory is non-compliant with the PM. Would you be interested in addressing it?
Thanks!
This change is