[GOG-1162] Fix Cluster Health Check to Skip HAProxy Validation in Bootstrap Mode #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurkss
changed the title
mfilipe
previously approved these changes
Jul 15, 2025
mfilipe
left a comment
mfilipe
left a comment
There was a problem hiding this comment.
The code in operator/redisfailover/service/check.go is straightforward. About the tests, I don't know exactly why you are checking the deployment pods, but it seems good.
indiebrain
reviewed
Jul 16, 2025
indiebrain
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with version 2.4.0 of the redis-operator, we are removing HAProxy from the cluster in bootstrap mode.
However, the cluster health check still expects HAProxy to be present.
As a result, the health check fails, preventing the Redis custom resource from updating its status and causing the deployment to fail.
Logic now distinguishes between:
Bootstrap mode with sentinels disabled → only Redis must be running.
Bootstrap mode with sentinels allowed → Redis and Sentinel must be running.
Normal mode → Redis, Sentinel, and HAProxy must all be running.