Lock MDSQLiteConnection._updateBuffer before accessing it#76
Merged
Conversation
Chriztiaan
previously approved these changes
Jul 8, 2026
Chriztiaan
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75.
The
FlushUpdatesmethod inMDSQLiteConnectionenumerates the_updateBufferproperty using LINQ, but this can fail if_updateBufferis modified partway through the enumeration. It also calls_updateBuffer.Clear()at the end of the function, which means any updates triggered between_updateBufferbeing enumerated and_updateBufferbeing cleared are dropped.This PR adds a lock around
_updateBufferand wraps all reads and writes of_updateBufferin said lock. I considered using aConcurrentQueue, but we would need a workaround forConcurrentQueue.Clear()since that method doesn't exist in .NET Standard 2.0 (it would probably also be slower).