-
Notifications
You must be signed in to change notification settings - Fork 60
Handle typo in powersync_url env variable #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HeinrichvonStein
merged 6 commits into
powersync-ja:main
from
HeinrichvonStein:env-variable-typo
Oct 29, 2024
Merged
Handle typo in powersync_url env variable #333
HeinrichvonStein
merged 6 commits into
powersync-ja:main
from
HeinrichvonStein:env-variable-typo
Oct 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1fdd1f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
reviewed
Oct 9, 2024
Contributor
Author
|
5a2bd21 to
606cde6
Compare
… into env-variable-typo
… into env-variable-typo
stevensJourney
approved these changes
Oct 23, 2024
Collaborator
stevensJourney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a trailing forward slash "/' is present in the POWERSYNC_URL environment variable, it causes the
GETrequest that writes a checkpoint to fail.This fix addresses issue #322 by throwing an error that lets a user know that they have made a typo. The error message appears as follows:
Logs:

Error notification:
This fix was tested with the following demos: