Skip to content

Conversation

@HeinrichvonStein
Copy link
Contributor

@HeinrichvonStein HeinrichvonStein commented Oct 7, 2024

When a trailing forward slash "/' is present in the POWERSYNC_URL environment variable, it causes the GET request that writes a checkpoint to fail.

This fix addresses issue #322 by throwing an error that lets a user know that they have made a typo. The error message appears as follows:

  • Logs:
    Screenshot 2024-10-23 at 12 40 04

  • Error notification:

Screenshot 2024-10-23 at 12 38 25
  • Console:
Screenshot 2024-10-23 at 12 38 38
  • In web console:
Screenshot 2024-10-23 at 09 50 06

This fix was tested with the following demos:

  • rn-supabase-group-chat
  • rn-supabase-todolist (demo that highlighted the issue)
  • react-supabase-todolist

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: 1fdd1f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@powersync/common Patch
@powersync/web Patch
@powersync/op-sqlite Patch
@powersync/react-native Patch
@powersync/tanstack-react-query Patch
@powersync/diagnostics-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HeinrichvonStein
Copy link
Contributor Author

  • introducing a new warning message

@HeinrichvonStein HeinrichvonStein marked this pull request as ready for review October 14, 2024 07:00
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HeinrichvonStein HeinrichvonStein merged commit 79d4211 into powersync-ja:main Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants