Skip to content

Handle typo in powersync_url env variable #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Handle typo in powersync_url env variable #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
606cde6
Handle typo in powersync_url env variable
HeinrichvonStein Oct 7, 2024
6153c56
Merge branch 'main' into env-variable-typo
HeinrichvonStein Oct 22, 2024
b2f0de8
Merge branch 'main' of https://github.com/HeinrichvonStein/powersync-…
Oct 23, 2024
da7bfc1
Add fetchCredentials response to error
Oct 23, 2024
ef461d5
Merge branch 'main' of https://github.com/HeinrichvonStein/powersync-…
Oct 23, 2024
1fdd1f6
Merge remote-tracking branch 'origin/env-variable-typo' into env-vari…
Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/fuzzy-bears-nail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@powersync/common': patch
'@powersync/web': patch
---

Handle additional forward slash in the POWERSYNC_URL environment variable
6 changes: 6 additions & 0 deletions packages/common/src/client/sync/stream/AbstractRemote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { version as POWERSYNC_JS_VERSION } from '../../../../package.json';

export type BSONImplementation = typeof BSON;

const POWERSYNC_TRAILING_SLASH_MATCH = /\/+$/;
export type RemoteConnector = {
fetchCredentials: () => Promise<PowerSyncCredentials | null>;
};
Expand Down Expand Up @@ -108,6 +109,11 @@ export abstract class AbstractRemote {
return this.credentials!;
}
this.credentials = await this.connector.fetchCredentials();
if (this.credentials?.endpoint.match(POWERSYNC_TRAILING_SLASH_MATCH)) {
throw new Error(
`A trailing forward slash "/" was found in the fetchCredentials endpoint: "${this.credentials.endpoint}". Remove the trailing forward slash "/" to fix this error.`
);
}
return this.credentials;
}

Expand Down