-
Notifications
You must be signed in to change notification settings - Fork 30
[Feature] Allow Building #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rkistner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check the details of the routers & routes, but the overall structure looks good to me.
How will we trigger publishing now without the journey-micro tooling?
Thanks! This repository has it's Docker Image published to DockerHub via a manual Github action. The hosted version in the other repository still uses the Journey Micro deploy tooling. The project there just imports and extends these packages. Local development of the hosted service can use our linking tooling to link core packages from this repository. Staging deploys can use development packages which can be published here from a manual Github action. |
Overview
This repository currently relies on some internal packages for Micro service functionality. These packages are published under a
restrictedscope which cannot be fetched by external users. This prevents external users from building or running the service locally (without using the precompiled Docker Image).This PR removes the dependency for the above packages. Allowing this repository to be used without any NPM credentials.
Changes
A minimal subset of the logic and definitions from the
@journeyapps-platform/microis now present in the@powersync/lib-services-frameworklibrary package. These definitions are used as a common interface for maintaining consistency with the service APIs between the open and hosted versions of the PowerSync service.Logging
Migrations
@powersync/service-corepackage.Mongo Locks
@powersync/service-corePluggable Interfaces
Containerinterface. Core logic will fetch the implementation from theContainerand use the registered implementation.serviceproject and Docker Image.@powersync/lib-services-frameworkpackage. This addresses some of the previous KLUDGE comments. Users could register HTTP probes etc in future.Routing
@powersync/lib-services-framework. These definitions are strictly not coupled to a specific router implementation, but do provide some plugins for use in Fastify. A small helper function is provided for connecting these route definitions to a Fastify instance. Note that this Fastify router does not support tracing. Concurrent connections are limited via a registered hook.Developing
Running this repository is now possible. Instructions for local development have been added.