Fix concurrency limit for websockets #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 909f71a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
commented
Jul 10, 2024
| code: '429', | ||
| // wss.clients.size includes this connection, so we check for greater than | ||
| // TODO: Share connection limit between this and http stream connections | ||
| if (max_concurrent_connections && wss.clients.size > max_concurrent_connections) { |
Contributor
Author
There was a problem hiding this comment.
Docs for wss.clients: https://github.com/powersync-ja/powersync-service/pull/36/files
The size of the set did seem to accurately reflect the number of concurrent connections in the testing I did.
stevensJourney
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24 introduced concurrency limits for websockets, similar to what we had with http streams. However, the connection count does not always decrease when a connection is closed, leading to all clients eventually getting an error " [429] Maximum active concurrent connections limit has been reached".
This simplifies it a bit by just tracking the number of websocket clients on the websocket server, instead of attempting to track the individual streams. We could additionally limit the number of streams per client in the future.