[MongoDB Storage] Fix occasional readConcern errors when using bulk_read_preference#710
Merged
Conversation
🦋 Changeset detectedLatest commit: 891bf8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
marked this pull request as ready for review
July 7, 2026 15:28
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57daa4b5e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
stevensJourney
previously approved these changes
Jul 7, 2026
stevensJourney
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
bulk_read_preference: secondaryPreferred, these errors occasionally come up:In #697, I originally went with this assumption from https://jira.mongodb.org/browse/DRIVERS-2860:
But it appears that assumption does not always hold here. Using
advanceClusterTimeas well is simple enough, and should resolve the issue.Note that this effectively includes
$clusterTimein the commands mongodb sends. It does not change how values are read, but should avoid the errors above. It may have additional implications for monotonic writes, but that should not affect our reads here.