fix: override _includes/head.html — minima 2.5.1 has no custom-head.html hook - #59
Merged
Conversation
…esn't exist in minima 2.5.1 Verified live after PR #58: the JSON-LD still wasn't rendering even with the correctly-named custom-head.html. Root cause: GitHub Pages builds with minima 2.5.1 (https://pages.github.com/versions/), and that release's head.html has no include hook for a custom-head.html at all — it was added in a later minima release than the one Pages actually runs (see jekyll/minima#472, a support thread about the exact same gap). A site-level _includes file always takes precedence over the theme gem's copy of the same path, so overriding _includes/head.html outright is version-proof: it works regardless of which minima release Pages resolves to, rather than depending on an extension point that may not exist yet. Content mirrors minima 2.5.1's head.html exactly, plus the two JSON-LD blocks. Also dropped the hardcoded softwareVersion field from the SoftwareApplication block — this repo has a dedicated test (test_version_consistency.py) specifically to prevent hand-maintained version literals from drifting, and a Jekyll include isn't covered by it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke (found by live-checking #58 after it deployed)
docs/_includes/custom-head.html(renamed correctly in #58) still never rendered on the live site. Root cause: GitHub Pages builds with minima 2.5.1 (per https://pages.github.com/versions/), and that release'shead.htmlhas no{% include custom-head.html %}call at all — that extension point was added in a later minima release than the one Pages actually resolves to. jekyll/minima#472 is a support thread about exactly this gap.Fix
Override
_includes/head.htmldirectly instead of relying on a theme extension hook. A site-level_includes/file always takes precedence over the theme gem's copy of the same path, so this works regardless of which minima version Pages happens to run — no dependency on an extension point that may or may not exist.The override mirrors minima 2.5.1's
head.htmlverbatim (meta tags,{% seo %}, stylesheet,feed_meta, conditional Google Analytics) plus the two JSON-LD blocks (SoftwareApplicationon home,TechArticleon processor/benchmark/comparison pages).Also dropped a hardcoded
softwareVersion: "2.7.1"I'd put in the JSON-LD — this repo hastest_version_consistency.pyspecifically to prevent hand-maintained version literals from drifting, and this include isn't covered by it, so better to just not add another one.Verification
<head>after this merges and Pages rebuilds — that's what caught both previous bugs, local validation alone missed them