[pull] master from PHPOffice:master#148
Merged
pull[bot] merged 2 commits intoppker:masterfrom Apr 30, 2026
Merged
Conversation
…s off writeCellFormula() falls back to using $cellValue (the formula source) as $calculatedValue when getPreCalculateFormulas() is false. The source is always a string, so the is_string($result) branch always fires, every formula cell ends up with t="str" — even those whose formula evaluates to a number or boolean. Some readers (notably older LibreOffice and Gnumeric) treat t="str" as a hint that the cell is a string, and either skip recomputation or present a #NAME error for numeric formulas they would otherwise compute correctly. Fix: leave $calculatedValue null and $calculatedValueString empty when pre-calc is off. The type-inference branches no longer fire, so no t attribute is written. The surrounding writeElementIf already guards <v> emission on getPreCalculateFormulas(), so no cached value is written either — readers see "formula with no cached value, no type hint", respect the workbook's fullCalcOnLoad="1", and recompute on open. Updates the existing PreCalcTest assertion to match: <c r="B2"><f>3+A3</f></c> instead of <c r="B2" t="str"><f>3+A3</f></c>.
…when-pre-calc-off Don't infer cell t attribute from formula source when pre-calc is off
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )