Prevent held non-modifier keys from re-triggering bindings after modifier release#6736
Merged
peppy merged 8 commits intoppy:masterfrom Apr 28, 2026
Merged
Conversation
Member
|
This needs some tests that fail on |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Piotrr0
commented
Apr 24, 2026
| AddStep("add container", () => | ||
| { | ||
| pressedActions.Clear(); | ||
| Child = new TestKeyBindingContainer(matchingMode: KeyCombinationMatchingMode.Modifiers) |
Contributor
Author
There was a problem hiding this comment.
In osu, GlobalActionContainer uses KeyCombinationMatchingMode.Modifiers https://github.com/ppy/osu/blob/c35782ce9cb04f3480e5dc35d3dea8cb7355c2f5/osu.Game/Input/Bindings/GlobalActionContainer.cs#L22
peppy
approved these changes
Apr 28, 2026
Member
peppy
left a comment
peppy
left a comment
There was a problem hiding this comment.
I think this makes sense. Fixes the observed issues and cannot find new breakage so let's give it a try.
peppy
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where releasing a modifier key while a non-modifier key is still held causes the non-modifier to "ghost", remaining in pressedInputKeys without belonging to any active binding. Any subsequent key press could then accidentally satisfy a binding that includes the held non-modifier, even though the user never made a new intentional press of it.
Closes ppy/osu#36779