Skip to content

Improve convert considerations in osu!taiko#31546

Merged
stanriders merged 8 commits intoppy:pp-devfrom
Lawtrohux:convert-fix
Jan 19, 2025
Merged

Improve convert considerations in osu!taiko#31546
stanriders merged 8 commits intoppy:pp-devfrom
Lawtrohux:convert-fix

Conversation

@Lawtrohux
Copy link
Member

@Lawtrohux Lawtrohux commented Jan 17, 2025

From the moment I had to implement it, blanket nerfing star rating of converts was something I severely disliked.

This change aims to

  • Remove conditional convert nerf to starrating, and focus on what becomes abuseable - stamina.
  • Harshen MonoStaminaFactor's accuracy curve, keeping the same performance points for the theoretical limits of stamina (an SS on a map like StrangeProgram)
  • Nerf stamina based on the concept that with most high-end converts, finger count gets increased by 150%, thus our considerations for stamina must be nerfed by 150%, as we assume a finger count of 4.
  • Disable the mono (single coloured) note buff that's found in stamina, to ensure that MonoStaminaFactor behaves correctly.
  • Clean up the instances of where stamina and relax share nerfs, and implement them in line.

This will 100% need a sheet, and some absolute scrutinisation of values @ppy/taiko-pp-commitee, I'm not repeating last deploy, and I hope to catch it much sooner if there's issues to be faced.

@Lawtrohux
Copy link
Member Author

@ppy/pp-maintainers could i also have a sheet here, thank you

@tsunyoku
Copy link
Member

!diffcalc
RULESET=taiko
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#31546

@github-actions
Copy link

@Lawtrohux Lawtrohux requested a review from a team January 18, 2025 12:40
@Lawtrohux
Copy link
Member Author

I'm personally happy with the sheet, as well as the feedback I've received from convert players.

Copy link
Member

@sw1tchbl4d3r sw1tchbl4d3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to the day we can drop the isConvert flag but for now this will have to suffice.

@stanriders stanriders requested a review from a team January 19, 2025 14:34
@stanriders
Copy link
Member

@tsunyoku you wanted to scrutinize this one extra hard iirc

@tsunyoku
Copy link
Member

Yeah, I did - whenever I see the word "convert" then I instantly feel a need to be extra cautious. This seems okay though - can continue.

@stanriders stanriders enabled auto-merge (squash) January 19, 2025 20:14
@stanriders stanriders merged commit e04727a into ppy:pp-dev Jan 19, 2025
7 of 9 checks passed
@Lawtrohux Lawtrohux deleted the convert-fix branch January 20, 2025 09:28
@tsunyoku tsunyoku moved this from Pending Deploy to Deployed in Difficulty calculation changes Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Deployed

Development

Successfully merging this pull request may close these issues.

4 participants