Improve convert considerations in osu!taiko#31546
Merged
stanriders merged 8 commits intoppy:pp-devfrom Jan 19, 2025
Merged
Conversation
Member
Author
|
@ppy/pp-maintainers could i also have a sheet here, thank you |
Member
|
!diffcalc |
Member
Author
|
I'm personally happy with the sheet, as well as the feedback I've received from convert players. |
sw1tchbl4d3r
approved these changes
Jan 19, 2025
Member
sw1tchbl4d3r
left a comment
There was a problem hiding this comment.
Looking forward to the day we can drop the isConvert flag but for now this will have to suffice.
Member
|
@tsunyoku you wanted to scrutinize this one extra hard iirc |
Member
|
Yeah, I did - whenever I see the word "convert" then I instantly feel a need to be extra cautious. This seems okay though - can continue. |
stanriders
approved these changes
Jan 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the moment I had to implement it, blanket nerfing star rating of converts was something I severely disliked.
This change aims to
MonoStaminaFactor's accuracy curve, keeping the same performance points for the theoretical limits of stamina (an SS on a map like StrangeProgram)mono(single coloured) note buff that's found in stamina, to ensure thatMonoStaminaFactorbehaves correctly.This will 100% need a sheet, and some absolute scrutinisation of values @ppy/taiko-pp-commitee, I'm not repeating last deploy, and I hope to catch it much sooner if there's issues to be faced.