Use correct HitWindows class for osu!taiko hit windows in difficulty calculator#31579
Merged
tsunyoku merged 6 commits intoppy:pp-devfrom Jan 20, 2025
Merged
Conversation
Member
Member
Author
|
!diffcalc |
…unyoku/osu into use-correct-taiko-hit-windows
Member
Author
|
!diffcalc |
Lawtrohux
approved these changes
Jan 20, 2025
Member
Lawtrohux
left a comment
Lawtrohux
left a comment
There was a problem hiding this comment.
Good catch. Changes are all reasonable or non-consequential
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught whilst porting over changes to osu!stable. This causes a noticable difference in the hit windows passed to the
Rhythmskill as Taiko hit windows are not the same as the default provided in theHitWindowsclass.Leaving it up to @ppy/taiko-pp-commitee to figure out what this means for their changes, but this is a non-negotiable fix.