Dynamic Star difficulty#3271
Closed
zachllogan wants to merge 14 commits intoppy:masterfrom
Closed
Conversation
Author
|
I did some tests, and from that beatmap set (https://osu.ppy.sh/beatmapsets/41242), the Level 1, Level 3, & Level 6 difficulties caused no problems, while the Origin, Saten, & Nyaten difficulties caused lazer to hang when trying to calculate their difficulty with the mania ruleset. |
Author
|
I pulled #3312 into a test branch, and it fixed the issue I had with calculating the mania difficulty of that mapset causing freezes. |
Contributor
|
No longer required after #9637 merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: It seems that for a subset of converted mania maps, running the difficulty calculator results in an infinite loop (lazer hangs indefinitely, so that is what I would assume). An example is this map set: https://osu.ppy.sh/beatmapsets/41242#osu/169520 (I haven't tested the maps individually; I probably will sometime and comment which one causes the issue).
Star Difficulty updates to account for selected mods & modes