Disable osu!catch catching animations in editor #32734
Open
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ppy#32615. We'll see what mappers say to this. I'm guessing no one will complain as it makes the editor less busy with lighting flashes and combo counters.
bdach
reviewed
Apr 8, 2025
| private readonly IBeatmapDifficultyInfo difficulty; | ||
|
|
||
| public CatchPlayfield(IBeatmapDifficultyInfo difficulty) | ||
| private readonly bool transferToCatcher; |
Collaborator
There was a problem hiding this comment.
can this be an init property instead of a ctor boolean parameter? I really don't like the latter, they're horrible for readability
also needs better documentation
Comment on lines
+115
to
+116
| if (transferToCatcher) | ||
| CatcherArea.OnNewResult((DrawableCatchHitObject)judgedObject, result); |
Collaborator
There was a problem hiding this comment.
while it would be quite convenient if all this did was disable the catching animation, that is not the case. it also disables anything to do with hyperdashing. hyperdash trails are gone, catcher afterimage and red tint are gone. none of this is listed in the OP, so I don't know whether this was intended, and so I have to ask.
Member
Author
There was a problem hiding this comment.
Probably needs more consideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32615.
We'll see what mappers say to this. I'm guessing no one will complain as it makes the editor less busy with lighting flashes and combo counters.