Log exception when it fails to load ruleset settings#36420
Closed
ilsubyeega wants to merge 2 commits intoppy:masterfrom
Closed
Log exception when it fails to load ruleset settings#36420ilsubyeega wants to merge 2 commits intoppy:masterfrom
ilsubyeega wants to merge 2 commits intoppy:masterfrom
Conversation
Member
|
This would send the error to us developers, which is not what we want. Could you explain why you think this change is necessary? (ie the use case you have for it) |
Contributor
Author
I didn't expect that, sorry for confusion
There is no detailed log about this, only showing single line/item, both client UI, log(in cli), log files. I wrote this PR since I wasn't able to check the error content/traces at that time, even in dev builds. |
peppy
added a commit
to peppy/osu
that referenced
this pull request
Jan 22, 2026
Supersedes and closes ppy#36420.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wasn't logging the exception to log for years, just got this when doing some stuffs there.