Fix crash when clicking panels during recycling#36457
Merged
bdach merged 4 commits intoppy:masterfrom Mar 6, 2026
Merged
Conversation
Member
|
Test coverage? |
peppy
force-pushed
the
fix-panel-click-null-reference
branch
from
9b9793f to
03f187a
Compare
Member
|
Added test coverage and adjusted code a bit. @bdach 5 minutes please. |
peppy
approved these changes
Mar 6, 2026
bdach
approved these changes
Mar 6, 2026
github-project-automation
bot
moved this from Pending Review
to Done
in osu! team task tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36246
This PR overrides
HandlePositionalInputto reject all positional input whenItemis null.