Adjust nightcore sample playback to not stop randomly and be closer to stable#36702
Merged
peppy merged 1 commit intoppy:masterfrom Feb 20, 2026
Merged
Adjust nightcore sample playback to not stop randomly and be closer to stable#36702peppy merged 1 commit intoppy:masterfrom
peppy merged 1 commit intoppy:masterfrom
Conversation
…o stable - Closes ppy#30293 - Fixes https://osu.ppy.sh/community/forums/topics/2179339?n=1 Aside from fixing the off-by-one error that I mentioned in ppy#30293 (comment), this also: - Brings back the behaviour wherein if timing points are arranged very weird and nightcore would play e.g. two first beats in a timing point back-to-back, the second timing point is silent. - Brings back the behaviour wherein the finish sample only plays if `OmitFirstBarLine` on the timing point is disabled. However: - This does not bring back the behaviour wherein hat samples only play if the slider tick rate is even because that only kind of makes sense in common time, and if common time is mixed with waltz time or other time signatures, it just gets weird. - Also stable has zero attempt for compensating for waltz time anyway, lazer's behaviour is bespoke, so that is not going to match any way you cut it. My testing procedure essentially consisted of getting stable to log when it was playing nightcore samples and cross-checking the first 30sec or so of https://osu.ppy.sh/beatmapsets/534385#osu/1131956 (check out the timing of that beatmap, for something ranked it is DEEPLY messed up). I guess I can add test cases if deemed required but I already wasted much more time than I would have liked here...
peppy
approved these changes
Feb 20, 2026
github-project-automation
bot
moved this from Pending Review
to Done
in osu! team task tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aside from fixing the off-by-one error that I mentioned in #30293 (comment), this also:
OmitFirstBarLineon the timing point is disabled.However:
My testing procedure essentially consisted of getting stable to log when it was playing nightcore samples and cross-checking the first 30sec or so of https://osu.ppy.sh/beatmapsets/534385#osu/1131956 (check out the timing of that beatmap, for something ranked it is DEEPLY messed up).
I guess I can add test cases if deemed required but I already wasted much more time than I would have liked here...