Disable presenting scores in online song selects#36826
Merged
peppy merged 1 commit intoppy:masterfrom Mar 5, 2026
Merged
Conversation
Closes ppy#36815 I guess. Song select V1 completely disabled the ability to view a score in ways that are very easy to let fly under the radar: https://github.com/ppy/osu/blob/5fc836d1f09cebf983313c9b91a5c252890c607a/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs#L26 https://github.com/ppy/osu/blob/46db3ad96d0e1cd6ba4176b9b474cb79a338965d/osu.Game/Screens/Select/PlaySongSelect.cs#L47-L53 therefore the issue this is trying to close would never even manifest there. The direct cause of the issue is that the results screen is pushed to the relevant online screen's *substack* of screens rather than the game-global parent stack. That means that when the back button is pressed, the following logic fires: https://github.com/ppy/osu/blob/6fa4a7152f144ed2524f20ecf7cfd26492bbe61d/osu.Game/Screens/OnlinePlay/OnlinePlayScreen.cs#L174-L189 This logic fires *on the parent screen* even though *the child screen* is the one the user is attempting to back out of. And none of the exemptions for the screen substack inside of the above method fire because the subscreen is not an `IOnlinePlaySubScreen` (it's `SoloResultsScreen` in this case). Now the direct cause here is probably fixable, although possibly not without some significant pulling of footer-shaped teeth. *However*, I kind of question as to why viewing scores should be permitted on online song selects in the first place - it kind of distracts from the primary purpose of the screens which is to *just pick a map already*.
peppy
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC. Closes #36815 I guess.
Song select V1 completely disabled the ability to view a score outside of solo play in ways that are very easy to let fly under the radar:
osu/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs
Line 26 in 5fc836d
osu/osu.Game/Screens/Select/PlaySongSelect.cs
Lines 47 to 53 in 46db3ad
therefore the issue this is trying to close would never even manifest there.
The direct cause of the issue is that the results screen is pushed to the relevant online screen's substack of screens rather than the game-global parent stack. That means that when the back button is pressed, the following logic fires:
osu/osu.Game/Screens/OnlinePlay/OnlinePlayScreen.cs
Lines 174 to 189 in 6fa4a71
This logic fires on the parent screen even though the child screen is the one the user is attempting to back out of. And none of the exemptions for the screen substack inside of the above method fire because the subscreen is not an
IOnlinePlaySubScreen(it'sSoloResultsScreenin this case).Now the direct cause here is probably fixable, although possibly not without some significant pulling of footer-shaped teeth. However, I kind of question as to why viewing scores should be permitted on online song selects in the first place - it kind of distracts from the primary purpose of the screens which is to just pick a map already.