Skip to content

Remove "copy labels from linked issues" github workflow#36854

Merged
peppy merged 1 commit intoppy:masterfrom
bdach:bork-bork-bork
Mar 6, 2026
Merged

Remove "copy labels from linked issues" github workflow#36854
peppy merged 1 commit intoppy:masterfrom
bdach:bork-bork-bork

Conversation

@bdach
Copy link
Collaborator

@bdach bdach commented Mar 6, 2026

It still doesn't work.

Looking at the job output it appears that the permissions of the GITHUB_TOKEN are automatically constrained to read even if you request more scopes. Would be nice if that was actually documented somewhere!

Also given supply-chain attacks that people are running on github via issue titles these days I'm not sure we want any automation near where it can reach code. Sure, much of the fault in the aforementioned attack was the fault of meatbags trusting clankers WAY too much, which is a mistake we would not do, but given everpresent software degradation from unknown sources and for unknown reasons let's not COPILOT ahem tempt fate...

It still doesn't work:

https://github.com/ppy/osu/actions/runs/22759488243/job/66012293202

Looking at the job output:

https://github.com/ppy/osu/actions/runs/22759488243/job/66012293202#step:1:21

it appears that the permissions of the `GITHUB_TOKEN` are
*automatically* constrained to `read` even if you request more scopes.
Would be nice if that was *actually documented* somewhere!

Also given supply-chain attacks that people are running on github via
issue titles these days
(https://grith.ai/blog/clinejection-when-your-ai-tool-installs-another)
I'm not sure we want any automation near where it can reach code. Sure,
much of the fault in the aforementioned attack was the fault of meatbags
trusting clankers *WAY* too much, which is a mistake we *would not* do,
but given everpresent software degradation *from unknown sources and
for unknown reasons* let's not ~~COPILOT~~ *ahem* tempt fate...
@bdach bdach self-assigned this Mar 6, 2026
@peppy peppy merged commit f9e863a into ppy:master Mar 6, 2026
6 of 8 checks passed
@peppy
Copy link
Member

peppy commented Mar 6, 2026

There's a setting in repo/org which is supposed to set the default permissions for the token, but I think it doesn't apply to PRs or something (I already checked and it's set in the permissive state).

was worth a try but automations like this are probably best living elsewhere or written ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants