Skip to content

Debounce user offline notifications#37028

Merged
peppy merged 3 commits intoppy:masterfrom
smoogipoo:offline-notice-debounce
Mar 18, 2026
Merged

Debounce user offline notifications#37028
peppy merged 3 commits intoppy:masterfrom
smoogipoo:offline-notice-debounce

Conversation

@smoogipoo
Copy link
Contributor

Closes #35586

This implements my proposal in the issue thread, debouncing offline state transitions to occur once every 15s for any user. It means that intermittent connections (of at least 1 second) or users toggling online/appear offline spam a little bit less.

Without debounce (normally period of intermittency would be 1s, so this is illustrative):

2026-03-18.16-49-43.mp4

With debounce (added in this PR):

2026-03-18.16-50-57.mp4

@smoogipoo smoogipoo added the area:online functionality Deals with online fetching / sending but don't change much on a surface UI level. label Mar 18, 2026
@smoogipoo smoogipoo self-assigned this Mar 18, 2026
@smoogipoo smoogipoo requested a review from a team March 18, 2026 07:57
@peppy peppy self-requested a review March 18, 2026 08:04
@peppy peppy enabled auto-merge (squash) March 18, 2026 18:41
@peppy peppy merged commit ed6ec8b into ppy:master Mar 18, 2026
5 of 9 checks passed
@peppy peppy deleted the offline-notice-debounce branch March 18, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:online functionality Deals with online fetching / sending but don't change much on a surface UI level. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification can be very noisy when a friend has poor network connection to server

2 participants