Simplify and consolidate distance variables used throughout aim evaluators#37124
Open
Finadoggie wants to merge 13 commits intoppy:pp-devfrom
Open
Simplify and consolidate distance variables used throughout aim evaluators#37124Finadoggie wants to merge 13 commits intoppy:pp-devfrom
Finadoggie wants to merge 13 commits intoppy:pp-devfrom
Conversation
Finadoggie
changed the title
Contributor
Author
|
I split the rhythm change off to its own branch to test that on its own and ensure it doesn't cause issues, may end up splitting this into more smaller branches for easier reviewability. https://pp.huismetbenen.nl/rankings/players/fina-saving-the-day |
Contributor
Author
|
Gonna split this into two prs: one for the refactor without changing values, and one which changes values. For now, refer to the PR that does not change values. This branch will be updated to fit that one later. |
Finadoggie
force-pushed
the
fix-bullshit
branch
from
1ba9817 to
644e678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to #37150 for now
This PR simplifies a lot of the complication regarding distance values by renaming variables and adding a GetDistance() function to be used when getting distance normally.
Deltas are present since the distances used in certain places are slightly different now. Notably, this deliberately reverts #36806, as that PR made it so the velocity used in certain areas was sometimes lower than what any player would actually experience, and would sometimes lead to velocity with sliders being lower than velocity without sliders.
https://pp.huismetbenen.nl/rankings/players/fina-playground-2