Improvements to discard screen UX#37245
Merged
smoogipoo merged 4 commits intoppy:masterfrom Apr 10, 2026
Merged
Conversation
This is needless. We already have the `DiscardFinish` stage which has a short countdown. Playing this change to the user creates unnecessary confusion.
Also remove custom colour support. We'll handle this internally in a better way in the future.
Felt like a bug.
smoogipoo
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just an initial grab bag to keep these PRs small.
Avoid showing countdown update when at discard screen
This is needless. We already have the
DiscardFinishstage which has ashort countdown. Playing this change to the user creates unnecessary
confusion.
Allow stage caption text to be changed at any point
Also remove custom colour support. We'll handle this internally in a
better way in the future.
Better explain why we're waiting after discarding our own cards