Fix multiple issues with ranked play card audio previews#37262
Merged
smoogipoo merged 5 commits intoppy:masterfrom Apr 12, 2026
Merged
Fix multiple issues with ranked play card audio previews#37262smoogipoo merged 5 commits intoppy:masterfrom
smoogipoo merged 5 commits intoppy:masterfrom
Conversation
They were playing during the animation if the user's mouse happened to be in the wrong place.
smoogipoo
approved these changes
Apr 12, 2026
Contributor
smoogipoo
left a comment
There was a problem hiding this comment.
Code seems extremely convoluted but I suppose it does what it says.
Member
Author
As per comment in OP, I'm just working with what is thrown at me at this point. I'd say the convoluted part is unavoidable based on what's already there. Refactor comes later or never we'll see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal here is to:
(I really want to rewrite all these classes, the structure is not great)