Skip to content

Fix multiple issues with ranked play card audio previews#37262

Merged
smoogipoo merged 5 commits intoppy:masterfrom
peppy:card-audio-preview-improvements
Apr 12, 2026
Merged

Fix multiple issues with ranked play card audio previews#37262
smoogipoo merged 5 commits intoppy:masterfrom
peppy:card-audio-preview-improvements

Conversation

@peppy
Copy link
Copy Markdown
Member

@peppy peppy commented Apr 10, 2026

The main goal here is to:

  • Make keyboard selection play previews just like hovering does with mouse.
  • Make sure cards don't play previews when they are in animation.
  • Drive by fix to fix toggling discard not working via keyboard.

(I really want to rewrite all these classes, the structure is not great)

Copy link
Copy Markdown
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems extremely convoluted but I suppose it does what it says.

@peppy
Copy link
Copy Markdown
Member Author

peppy commented Apr 12, 2026

Code seems extremely convoluted but I suppose it does what it says.

As per comment in OP, I'm just working with what is thrown at me at this point. I'd say the convoluted part is unavoidable based on what's already there. Refactor comes later or never we'll see.

@smoogipoo smoogipoo merged commit 0e9664b into ppy:master Apr 12, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants