Add support for grouping by keys in song select for osu!mania#37285
Merged
peppy merged 2 commits intoppy:masterfrom Apr 15, 2026
Merged
Add support for grouping by keys in song select for osu!mania#37285peppy merged 2 commits intoppy:masterfrom
peppy merged 2 commits intoppy:masterfrom
Conversation
See ppy#35207 Of note: - Supports both native beatmaps and converts - Supports key mods (changing key mods will trigger song select refilter when key count grouping is engaged) - The option to group by keys is only visible when mania ruleset is active - If the user selects key count grouping and then switches to another ruleset, song select will fall back to no grouping, but this change will not be written back to config. Only the user changing the grouping mode manually will reflect in config changes. This is done so that key grouping persists across ruleset changes, and this even survives game restarts.
peppy
approved these changes
Apr 15, 2026
Comment on lines
+419
to
+421
| // Ordering important - base call must run *after* the above bindings | ||
| // because the bindings set up `Items`, and the base call is responsible for calling `GenerateItemText()`. | ||
| base.LoadAsyncComplete(); |
Member
There was a problem hiding this comment.
This puts me on the edge of my seat but sure.
peppy
approved these changes
Apr 15, 2026
github-project-automation
bot
moved this from Pending Review
to Done
in osu! team task tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
final.mov
Of note:
I've only done some light behaviour testing on this because this feature needs a lot of subjective shot calls and I don't want to commit too deep before I get a temperature check on the shot calls I made here.
In particular some performance profiling of 7de8f70 may be warranted.