Add bottom 'ornament' overlay to ranked play#37288
Merged
peppy merged 5 commits intoppy:masterfrom Apr 14, 2026
Merged
Conversation
This commit adds an always present overlay to all ranked play screens, meant to indicate to the user that a ranked play session in currently in progress.
Member
|
I'd really like to add more animation to the path part of this, but it's a bit hard to orchestrate with the way it's structured atm. |
Contributor
Author
|
I'd probably have to pull out the |
peppy
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an always present overlay to all ranked play screens, meant to indicate to the user that a ranked play session in currently in progress.
This has been largely inspired by the pre-shader argon healthbar code. It shouldn't have the same performance concerns, however, since the paths are only calculated once when loading the drawable (and eventually when it is resized, if ever).
RankedPlayScreen:Gameplay:
Currently the drawable overlaps with some components, but it will be resolved in later pull requests.