Skip to content

Add bottom 'ornament' overlay to ranked play#37288

Merged
peppy merged 5 commits intoppy:masterfrom
LiquidPL:ranked-play-bottom-ornament
Apr 14, 2026
Merged

Add bottom 'ornament' overlay to ranked play#37288
peppy merged 5 commits intoppy:masterfrom
LiquidPL:ranked-play-bottom-ornament

Conversation

@LiquidPL
Copy link
Copy Markdown
Contributor

This commit adds an always present overlay to all ranked play screens, meant to indicate to the user that a ranked play session in currently in progress.

This has been largely inspired by the pre-shader argon healthbar code. It shouldn't have the same performance concerns, however, since the paths are only calculated once when loading the drawable (and eventually when it is resized, if ever).

RankedPlayScreen:

image

Gameplay:

image

Currently the drawable overlaps with some components, but it will be resolved in later pull requests.

This commit adds an always present overlay to all ranked play screens,
meant to indicate to the user that a ranked play session in currently
in progress.
@peppy peppy self-requested a review April 14, 2026 02:05
@peppy
Copy link
Copy Markdown
Member

peppy commented Apr 14, 2026

I'd really like to add more animation to the path part of this, but it's a bit hard to orchestrate with the way it's structured atm.

@LiquidPL
Copy link
Copy Markdown
Contributor Author

I'd probably have to pull out the SliderPath parts out to some place where they're defined once on load (probably should have done that in the first place), so that they can then be used to drive any interpolations that would animate the paths.

Copy link
Copy Markdown
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass looks okay

@peppy peppy merged commit 16a2a96 into ppy:master Apr 14, 2026
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants