Add already existing localisation support from CommonStrings#37401
Merged
peppy merged 5 commits intoppy:masterfrom May 6, 2026
Merged
Add already existing localisation support from CommonStrings#37401peppy merged 5 commits intoppy:masterfrom
CommonStrings#37401peppy merged 5 commits intoppy:masterfrom
Conversation
diquoks
commented
Apr 19, 2026
| case DownloadState.Importing: | ||
| Background.FadeColour(colours.Yellow, 500, Easing.InOutExpo); | ||
| TooltipText = "Importing"; | ||
| TooltipText = CommonStrings.Importing; |
Contributor
Author
There was a problem hiding this comment.
string here now has an ellipsis, unlike the original version, but i think it will be even better this way
diquoks
force-pushed
the
localisation/common-strings
branch
from
0e3f382 to
d81d9c5
Compare
peppy
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decided to do this mostly because of the non-localised
BackButtonthat was bothering my eyeschanges can be reviewed commit by commit