Code quality improvements for child/draw order handling in HandOfCards#37423
Merged
peppy merged 4 commits intoppy:masterfrom Apr 21, 2026
Merged
Code quality improvements for child/draw order handling in HandOfCards#37423peppy merged 4 commits intoppy:masterfrom
HandOfCards#37423peppy merged 4 commits intoppy:masterfrom
Conversation
minetoblend
force-pushed
the
rp-handofcards-codequality
branch
from
ef9a137 to
4f24c68
Compare
Member
|
FWIW I'm still very weirded out by the use of |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at adressing the points made in #37419 (comment)
CardContaineris now being sorted immediately instead of only doing it once per frame. Given that its only ever gonna have a handful of children there wasn't really a need to optimize that that in the first place.HandOfCards.Cardsnow exposescardLookup.Valuesas anIEnumerableinstead of exposing the card container's children directly.HandOfCardnow exposesGetCardsInDisplayOrderwhich returns a copy of all cards in display order. Since it's making a copy I made sure this isn't called on any hot code paths.HandOfCard.Clearpreviously didn't clear thecardLookupdictionary. Didn't cause any issues since we're not re-adding cards to the hand anywhere but not good regardless.Switched to looping over all cards and calling
RemoveCardto make sure changes to the removal logic can't get overlooked there again.