Add pen input settings#37500
Conversation
|
Is this the best we can do? There's no toggle in SDL3 to just restore the previous behaviour? If we're going down this path I recommend we name this section "Tablet (External)" to make it very obvious what is going on. |
To me, this is the correct solution, anything else would be a hack. Having separate mouse and pen sensitivity was my solution to this all along, as relative mouse events in SDL3 don't work well with osu!'s needs for absolute input.
This never worked with native SDL2, we had our custom handler that did external tablet sensitivity. SDL3 implementes something very similar to our custom handler, but exposes it through pen events instead of mouse events. It's just a matter of interface, but the end result is the same. Theoretically, we could roll our custom handler with SDL3, but it would require disabling the raw mouse input thread – our whole reason for upgrading to SDL3. |
Never mind I understand now. |
aa6a9cf to
d5b0ab5
Compare
- Bump ppy.osu.Framework/Android/iOS from 2026.427.4 to 2026.428.2 (winnerspiros/osu-framework PR #25: merge 4 upstream commits including pen sensitivity setting support for SDL3 + winnerspiros Vulkan fixes) - Update ppy.osu.Game.Resources to 2026.427.0 (from upstream) - Cherry-pick ppy/osu commit 9b3dba9 (Add pen input settings ppy#37500): adds PenSettings.cs, PenSettingsStrings.cs, OsuConfigManager pen sensitivity config entry, OsuGameBase pen handler settings wiring Fork customizations preserved: - ppy.Veldrid.SPIRV pinned at 1.0.15-gb268bf39ea (16 KB page-aligned build) - ppy.osu.Framework.NativeLibs ExcludeAssets=all (Android native lib fix) - All Android/Oboe/safe-mode/crash-diagnostics fork code untouched Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Adds simple input settings section for pens that allows disabling the handler and adjusting sensitivity. The section appears in-between Tablet and Touch, and only on SDL3 (desktop and mobile). The pen sensitivity is completely independent from mouse sensitivity.
Keep in mind that the "Confine mouse cursor to window" mouse setting also affects pens, feel free to suggest UX improvements. Also, toggling "High precision mouse" might affect pens on certain configurations.
Edit: added image with updated header. Previously, it was "Device: Pen".