Hide red failing layer in ranked play#37503
Merged
peppy merged 1 commit intoppy:masterfrom Apr 24, 2026
Merged
Conversation
LittleEndu
reviewed
Apr 24, 2026
| AllowRestart = false, | ||
| AutomaticallySkipIntro = room.AutoSkip, | ||
| ShowLeaderboard = true, | ||
| ShowFailingOverlay = false |
Contributor
There was a problem hiding this comment.
So this is false because of there's no revival in multiplayer yet? And once revival is implemented it will be changed to showFailingOverlay because right now that function argument is unused???
Contributor
Author
There was a problem hiding this comment.
Whoops that's not intended.
smoogipoo
force-pushed
the
rp-hide-failing-layer
branch
from
e62420b to
46b7b8f
Compare
peppy
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ranked play, scores are always counted regardless of whether they are a fail or a pass. Beyond that, there's also no concept of revival in multiplayer right now, so players are just stuck at 0 HP with a red overlay.
Not doing what
ModNoFaildoes, which is to hide the healthbar altogether, because some user skins use the healthbar to skin a gameplay border.