Implement animation for RankedPlayBottomOrnament#37504
Merged
peppy merged 5 commits intoppy:masterfrom Apr 27, 2026
Merged
Conversation
This commit rewrites the separate `SmoothPath`s to be handled by a single `SliderPath`, so that they can be animated in a consistent manner, and then uses that to create a cool looking animation where the path expands from the middle to the sides. I am not sure about the performance impact of repeatedly calling `GetPathToProgress` every frame, but I also couldn't find a way to somehow precache the vertices in a way I could retrieve them for an arbitrary progress. Either way I believe this shouldn't impact things too negatively.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
test crashes. |
Contributor
Author
Bad habit running tests on release. |
peppy
approved these changes
Apr 27, 2026
peppy
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of #37478 with some improvements such as:
progresshandling (single adjustable value instead of 2)