Basic Map Info in Ranked Result Screen#37550
Closed
pacowoc wants to merge 9 commits intoppy:masterfrom
Closed
Conversation
Author
fixes up the visuals a bit
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private LoadingSpinner loadingSpinner = null!; | ||
| private MainPanel? mainPanel; | ||
|
|
||
| public ResultsScreen() : base(true) |
Author
|
Will be adding a background and colored border once I have time |
Member
|
I'm not sure this should be implemented in the stage display. You've worked around the fact that the stage display is global to all ranked play screens with a bool, without asking yourself "why" you put it in there as opposed to on the results screen itself (the one place this should probably be displayed?) |
peppy
added a commit
that referenced
this pull request
Apr 28, 2026
Different take to / supersedes / closes #37550 Just going for minimal lines of code compared to the PR above, by reusing the quick play panel which is in a pretty good state. <img width="1298" height="864" alt="image" src="https://github.com/user-attachments/assets/409e163d-d7ea-4c07-874f-aaca7e145221" /> --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
Copilot AI
pushed a commit
to winnerspiros/osu
that referenced
this pull request
Apr 28, 2026
Different take to / supersedes / closes ppy#37550 Just going for minimal lines of code compared to the PR above, by reusing the quick play panel which is in a pretty good state. <img width="1298" height="864" alt="image" src="https://github.com/user-attachments/assets/409e163d-d7ea-4c07-874f-aaca7e145221" /> --------- Co-authored-by: Dean Herbert <pe@ppy.sh> Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have recieved request from reddit to include this feature for screenshot purposes
