Synchronise ranked play text box with gameplay text box#37630
Merged
peppy merged 4 commits intoppy:masterfrom May 5, 2026
Merged
Synchronise ranked play text box with gameplay text box#37630peppy merged 4 commits intoppy:masterfrom
peppy merged 4 commits intoppy:masterfrom
Conversation
peppy
reviewed
May 4, 2026
Contributor
Author
|
The way I originally implemented it gave me the results by accident, as it was I've removed the bindable on the channel now and the listener. Now I've only implemented the bindings for the textbox once |
peppy
approved these changes
May 5, 2026
peppy
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if it was intentionally not included, but with quick play the unsent text input would be transferred to the gameplay state. This video shows how it currently acts:
ranked.text.input.not.transferring.mp4
But I have used some of the logic in the
channelChangedfunction fromStandAloneChatDisplay, and managed to get the text boxes to synchronise in the gameplay state.ranked.fixed.text.transfer.mp4