Skip to content

Synchronise ranked play text box with gameplay text box#37630

Merged
peppy merged 4 commits intoppy:masterfrom
smyalygames:ranked-chat-textbox
May 5, 2026
Merged

Synchronise ranked play text box with gameplay text box#37630
peppy merged 4 commits intoppy:masterfrom
smyalygames:ranked-chat-textbox

Conversation

@smyalygames
Copy link
Copy Markdown
Contributor

I am not sure if it was intentionally not included, but with quick play the unsent text input would be transferred to the gameplay state. This video shows how it currently acts:

ranked.text.input.not.transferring.mp4

But I have used some of the logic in the channelChanged function from StandAloneChatDisplay, and managed to get the text boxes to synchronise in the gameplay state.

ranked.fixed.text.transfer.mp4

@peppy peppy self-requested a review May 4, 2026 15:31
@pull-request-size pull-request-size Bot added size/XS and removed size/M labels May 4, 2026
@smyalygames
Copy link
Copy Markdown
Contributor Author

The way I originally implemented it gave me the results by accident, as it was textbox.Current.BindTo(channel.TextBoxMessage); was run once the channel was created in RankedPlayChatDisplay as that changed the value of the channel.

I've removed the bindable on the channel now and the listener. Now I've only implemented the bindings for the textbox once RankedPlayChatDisplay has loaded.

@peppy peppy self-requested a review May 5, 2026 06:51
@peppy peppy merged commit 5fb87da into ppy:master May 5, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants