Fix non-default mod settings allowing for duplicate freestyle mod selection in multiplayer#37646
Merged
bdach merged 5 commits intoppy:masterfrom May 7, 2026
Merged
Conversation
… of strict settings equality
… mod selection in multiplayer
triacontakai
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
smoogipoo
previously approved these changes
May 7, 2026
…lity of multiple instances of same mod
bdach
approved these changes
May 7, 2026
Collaborator
bdach
left a comment
bdach
left a comment
There was a problem hiding this comment.
I added another less roundabout test for this, but seems fine.
Thankfully this is also checked web-side so the blast radius of this is limited to just the local client, this can't really spill out any further.
Copilot AI
pushed a commit
to winnerspiros/osu
that referenced
this pull request
May 7, 2026
…ection in multiplayer (ppy#37646) Fixes a bug that allowed for selecting the same mod twice in multiplayer if the playlist entry has non-default settings for a required mod. This happens due to a strict equality mod check in the mod set compatibility check function, which only considers mods duplicates if their settings are exactly the same. Replacing with a more lenient `Type` check fixes this. Adds a regression test for this behavior Fixes ppy#37625. --------- Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com> Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that allowed for selecting the same mod twice in multiplayer if the playlist entry has non-default settings for a required mod.
This happens due to a strict equality mod check in the mod set compatibility check function, which only considers mods duplicates if their settings are exactly the same. Replacing with a more lenient
Typecheck fixes this.Adds a regression test for this behavior
Fixes #37625.