Skip to content

Restore editor mode when changing difficulty#37671

Merged
bdach merged 2 commits intoppy:masterfrom
peppy:remember-editor-mode
May 8, 2026
Merged

Restore editor mode when changing difficulty#37671
bdach merged 2 commits intoppy:masterfrom
peppy:remember-editor-mode

Conversation

@peppy
Copy link
Copy Markdown
Member

@peppy peppy commented May 8, 2026

When editing metadata, it's annoying that the editor returns to compose mode when switching between difficulties. This fixes that fallacy.

Supersedes and closes #36724.

peppy added 2 commits May 8, 2026 16:03
When editing metadata, it's annoying that the editor returns to compose
mode when switching between difficulties. This fixes that fallacy.
@bdach
Copy link
Copy Markdown
Collaborator

bdach commented May 8, 2026

Just to confirm: this was attempted once in #36724. You tried to touch that PR up but then ended up adding a lot of schedule stuff in 4067b11 that I took issue with in review.

This doesn't have any of that, and is considerably simpler as such, but then may have an issue of multiple screen loads.

What am I to do at this point?

@peppy
Copy link
Copy Markdown
Member Author

peppy commented May 8, 2026

You have a better memory than I.

Let's see how tests look on this and go with it if you/tests don't break it. There's a weird flicker when loading but it's not enough to outweigh the usability improvement, and I'm not really interested in fixing it for now.

I'm kinda interested in recent times in getting the actual core issues fixed and then worrying about the more minor details (like two screens maybe being loaded unnecessarily) later on.

@bdach bdach self-requested a review May 8, 2026 08:20
@bdach bdach merged commit e6fdd37 into ppy:master May 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants