Change editor grid slider adjustments to be relative to centre#37737
Merged
Conversation
As requested in ppy#37734. Quick one, seems beneficial.
Collaborator
|
@OliBomby any objections? |
Contributor
No objections. This makes sense |
bdach
approved these changes
May 13, 2026
Collaborator
bdach
left a comment
bdach
left a comment
There was a problem hiding this comment.
Frankly shocked that this five-way bindable synchronisation setup doesn't die on stack overflows because in general you can't do this type of stuff because of floats.
float p = 19.1f;
Console.WriteLine(p); // 19,1
float q = p + 256;
float r = q - 256;
Console.WriteLine(r); // 19,100006
Console.WriteLine(p == r); // FalseIt's probably salvaged by BindableNumber.Precision. Couldn't get it to crash on a quick manual check and I'm not doing a sweep over all values of float to be sure. Prolly just gonna fix in post if it does actually ever crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #37734.
Quick one, seems beneficial.