Update star rating in song select statistics when changing mods/mod settings#7382
Closed
huoyaoyuan wants to merge 2 commits intoppy:masterfrom
Closed
Update star rating in song select statistics when changing mods/mod settings#7382huoyaoyuan wants to merge 2 commits intoppy:masterfrom
huoyaoyuan wants to merge 2 commits intoppy:masterfrom
Conversation
bdach
added
area:mods
area:song-select
type/cosmetic
huoyaoyuan
changed the title
huoyaoyuan
force-pushed
the
mod-star-changes
branch
from
1b9a1b6 to
70e3c79
Compare
huoyaoyuan
force-pushed
the
mod-star-changes
branch
from
70e3c79 to
4646cc0
Compare
Member
|
At very least, the colouring needs to change for SR. Orange on red is not a good look. |
Contributor
Author
|
|
Contributor
|
No longer required after #9637 merge |
Contributor
Author
|
Sure. But I wish to be mentioned when there's something going to replace my work, and I can take part in the discussion. |
Member
|
does this have functionality not in master still in terms of display? |
Contributor
|
It doesn't. @huoyaoyuan sorry about that - I forgot this PR existed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to #7303 , the implementation becomes very simple.
HardRock:
DoubleTime:
But, I'm afraid we are on the wrong way of beatmap details processing. There should be a centralized "Playable state of beatmap", in contrast of "original beatmap", and all the displaying should simply read from the playable state.
Also, there needs a redesign of beatmap info UI.