[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon - #149
Open
Jiggly-Balls wants to merge 8 commits into
Open
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon#149Jiggly-Balls wants to merge 8 commits into
Jiggly-Balls wants to merge 8 commits into
Conversation
Jiggly-Balls
added
chore
Xarlos89
requested changes
Jul 4, 2026
Xarlos89
left a comment
Xarlos89
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, but I think you missed the API dockerfile
| from routes.settings import settings | ||
| from werkzeug.exceptions import HTTPException | ||
|
|
||
| from src.api.__logger__ import setup_logger |
Collaborator
There was a problem hiding this comment.
Nothing was changed in the API startup command in the dockerfile. Does this actually work without changing the startup command?? No way
Collaborator
Author
There was a problem hiding this comment.
Yeah, I remember testing long ago. It should work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your PR
This PR fixes the
cog_loadmethod insrc.bot.cogs.features.MonthlyYapathonfrom a sync method to an async method. Also fixes the implicit import type error by making all project level imports from relative & implicit relative to absolute imports.Due to this I had to also update the extension loading slightly and the final run command of the bot in
Dockerfile-bot. Additionally I also added aBaseCogclass which comes with some logging when the cogs gets loaded / unloaded.Describe your changes
Added
src.bot.cogs.BaseCogfile which comes with some logging.Fixed
cog_loadmethod ofMonthlyYappathonfrom sync to async.reportImplicitRelativeImportChanged
src/bot/main.pyIssue link
Closes #147
Closes #148
Checklist
pre-commitover your PR?master?master?