Skip to content

Modernization 202603: Update rodio to the official crate, update cpal and most dependencies#54

Merged
pragmatrix merged 9 commits intomasterfrom
modernize-202603
Mar 29, 2026
Merged

Modernization 202603: Update rodio to the official crate, update cpal and most dependencies#54
pragmatrix merged 9 commits intomasterfrom
modernize-202603

Conversation

@pragmatrix
Copy link
Copy Markdown
Owner

@pragmatrix pragmatrix commented Mar 29, 2026

Manual tests:

  • Open AI Dialog
  • Azure Transcribe
  • Azure Synthesize
  • Azure Translate
  • Google Transcribe Not Needed for now.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the Rust workspace by switching to the official rodio crate and updating cpal and a broad set of other dependencies, with accompanying code updates to match newer APIs (notably around audio playback and WebSocket message types).

Changes:

  • Update audio stack dependencies (notably rodio, cpal) and adapt playback code to newer NonZero*-based APIs.
  • Update WebSocket server code for newer axum APIs (listener tapping, message payload types) and minor protocol parsing refactors.
  • Bump crate versions to 2.0.0 and refresh several dependency versions across services/examples.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
services/playback/src/lib.rs Update rodio conversion/resampling call sites to NonZeroU16/NonZeroU32 and enforce non-zero output format fields.
services/playback/Cargo.toml Bump bytes dependency.
services/openai-dialog/src/lib.rs Import ordering cleanup and comment typo fix.
services/openai-dialog/Cargo.toml Bump tokio-tungstenite version.
services/google-transcribe/src/lib.rs Replace boxed interceptor closure with a tonic::service::Interceptor implementation.
filter-test/Cargo.toml Bump fundsp version.
examples/openai-dialog.rs Update rodio playback API usage and adjust format/sample-rate handling for newer cpal/rodio types.
examples/azure-translate.rs Update rodio playback API usage; keep an output sink alive for Bluetooth headset profile switching; split input/output formats.
examples/azure-transcribe.rs Keep output sink alive for Bluetooth headsets; improve error context for default input device; adjust sample rate handling.
examples/azure-synthesize.rs Update rodio playback API usage and Source trait signature changes.
examples/azure-container.rs Keep output sink alive for Bluetooth headsets; adjust sample rate handling.
examples/aristech-transcribe.rs Keep output sink alive for Bluetooth headsets; adjust stream config/sample rate handling for newer cpal.
examples/aristech-synthesize.rs Update rodio playback API usage and Source trait signature changes.
core/Cargo.toml Bump context-switch-core version to 2.0.0.
audio-test/Cargo.toml Bump tracing-subscriber and indicatif versions.
audio-knife/src/mod_audio_fork.rs Adjust WebSocket message construction to new Message payload types.
audio-knife/src/main.rs Update axum routing and server setup (per-connection TCP_NODELAY via listener tap); adjust WS ping/pong payload type handling; JSON decoding refactor.
audio-knife/Cargo.toml Bump audio-knife version and update axum dependency.
Cargo.toml Bump workspace crate version, rust-version, and many dependency versions; switch from local rodio submodule to crates.io.
.gitmodules Remove rodio submodule and update openai submodule branch value.
.github/copilot-instructions.md Add repository-specific coding/style instructions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread services/playback/src/lib.rs
Comment thread Cargo.toml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pragmatrix pragmatrix merged commit 076a49f into master Mar 29, 2026
6 checks passed
@pragmatrix pragmatrix deleted the modernize-202603 branch March 29, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants