Prompt tests#70
Merged
Merged
Conversation
10 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve prompt handling in the openai-dialog service by introducing a prompt-delay feature (with default enablement) and adding developer ergonomics for sending prompts via stdin/FIFO while running the dialog example.
Changes:
- Introduces a
prompt-delayfeature (enabled by default) and refactors prompt scheduling into aPromptCoordinator. - Updates prompt sending/error handling paths to support delayed prompt dispatch and rescheduling on active-response conflicts.
- Enhances the
dialogexample andjustfileto support sending prompts interactively (stdin) and via a FIFO workflow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| services/openai-dialog/src/client.rs | Refactors prompt dispatch into a feature-gated coordinator and adds shared prompt-send helper. |
| services/openai-dialog/Cargo.toml | Adds prompt-delay feature and enables it by default. |
| justfile | Adds FIFO-based helper recipes for sending prompts to the dialog example. |
| examples/dialog.rs | Adds stdin-driven prompt injection while the audio dialog runs. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds prompt tests and improves the prompting delay logic in the openai-dialog service.