Merged
Conversation
127170f to
a3ac0fd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines “pointer feedback” behavior (hover rect + cursor visibility) so it can be disabled on keyboard interaction and re-enabled based on subsequent pointer activity, while also simplifying hover-rect motion behavior.
Changes:
- Add a window API wrapper to toggle cursor visibility and cache cursor-visible state in
Desktop. - Add cursor “velocity” detection using recent input history to decide when to re-enable pointer feedback.
- Simplify hover-rect state by removing rect animation (rect is now updated directly while alpha remains animated).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
shell/src/shell_window.rs |
Adds set_cursor_visible wrapper for window cursor visibility control. |
input/src/event.rs |
Adds cursor_has_velocity() helper based on event history. |
desktop/src/projects/project_presenter.rs |
Removes hover-rect animation; keeps alpha animation and applies rect directly. |
desktop/src/event_router.rs |
Exposes keyboard_focus_change() to avoid re-querying focus state. |
desktop/src/desktop_system.rs |
Introduces pointer_feedback_enabled and logic to disable/reenable hover/cursor feedback. |
desktop/src/desktop.rs |
Caches and applies cursor visibility changes to the shell window. |
.github/copilot-instructions.md |
Adds guidance about shared state for affordances and caching window state requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.